Event: remove preDispatch hook & simplify "simulate" signature - #2358
Closed
markelog wants to merge 1 commit into
Closed
Event: remove preDispatch hook & simplify "simulate" signature#2358markelog wants to merge 1 commit into
markelog wants to merge 1 commit into
Conversation
Member
|
It doesn't take up much room. Maybe we should document? |
Member
Author
Okay, so to not wiggle about with this pull, i will remove changes of Sounds good? |
Member
|
👍 |
Member
|
Sounds good to me. |
Member
|
Yup, +1
|
Member
Author
|
Yeah, yeah i got it :-), will land it soon |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I bet there is more like that in there
/cc @dmethvin