Fix Windows test failure for temurin signature verification and add e2e coverage#5
Merged
johnoliver merged 1 commit intoJun 17, 2026
Conversation
Copilot
AI
changed the title
Fix Windows test failure and add temurin GPG signature e2e test
Fix Windows test failure for temurin signature verification and add e2e coverage
Jun 17, 2026
Copilot created this pull request from a session on behalf of
johnoliver
June 17, 2026 14:53
View session
johnoliver
approved these changes
Jun 17, 2026
johnoliver
merged commit c607d20
into
copilot/include-signature-verification
240 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
On
windows-latest,process.platform === 'win32'causesrenameWinArchive()to runfs.renameSyncon the mocked download path/tmp/jdk.tar.gz, which doesn't exist on disk — throwingENOENT. Fix mocksutil.renameWinArchivein thedownloadTooltest suite alongside the other already-mocked util functions. Also adds an e2e job exercising the fullverify-signature: trueflow for Temurin.__tests__/distributors/temurin-installer.test.ts— addspyRenameWinArchivemock indownloadToolbeforeEachto preventfs.renameSyncfrom touching the filesystem during the signature verification test.github/workflows/e2e-versions.yml— newsetup-java-temurin-signature-verificationjob runningverify-signature: truefor Temurin 17 and 21 across macOS, Windows, and LinuxRelated issue:
Check run 81923318772
Check list: