Add gpg signature verification#4
Draft
Copilot wants to merge 6 commits into
Draft
Conversation
Copilot created this pull request from a session on behalf of
johnoliver
June 17, 2026 14:36
View session
…failure Fix Windows test failure for temurin signature verification and add e2e coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gpg.tscontainedADOPTIUM_SIGNATURE_KEY_FINGERPRINTas an exported constant and used it as the default forkeyFingerprintinverifyPackageSignature(), making the module look Adoptium-specific despite being a shared utility.Changes:
src/gpg.ts: RemovedADOPTIUM_SIGNATURE_KEY_FINGERPRINTconstant; madekeyFingerprinta required parameter inverifyPackageSignature()(no distro-specific default); removed Adoptium-specific commentsrc/distributions/temurin/installer.ts: Addedexport const ADOPTIUM_SIGNATURE_KEY_FINGERPRINThere, where it belongs; updated call site to use the local constantgpg.test.tsto pass an explicit fingerprint; updatedtemurin-installer.test.tsto import the constant from the temurin installer instead ofgpgCheck list: