Skip to content

Restore 100% unit test coverage - #141

Closed
tseaver wants to merge 6 commits into
joestump:masterfrom
tseaver:coverage
Closed

tseaver wants to merge 6 commits into
joestump:masterfrom
tseaver:coverage

Conversation

@tseaver

@tseaver tseaver commented May 28, 2013

Copy link
Copy Markdown
Contributor

Document the supported versions using Trove classifiers.

Test against all supported Python versions (2.5 - 2.7) using tox.

Test coverage separately (using 'tox -e cover').

Add tests to restore 100% coverage.

tseaver added 4 commits May 28, 2013 15:19
- Add Trove classifiers for supported Python versions.

- Test supported Python versions using tox.
@joestump

Copy link
Copy Markdown
Owner

cc @jaitaiwan I think we should fold this into our CI work. Not sure if tox is needed for that work, but I'd like to get the test coverage and other fixes in.

@jaitaiwan

Copy link
Copy Markdown
Contributor

I'd like to see this folded into the CI stuff although Travis already provides multiple CI python versions... unless tox does this differently somehow?

@tseaver

tseaver commented Jul 29, 2015

Copy link
Copy Markdown
Contributor Author

FWIW, the key feature of tox is that it allows the developer to run the tests locally before pusing (assuming she has the appropriate Python versions available). Travis can then be used to drive tox. For instance, see:

@tseaver

tseaver commented Jul 29, 2015

Copy link
Copy Markdown
Contributor Author

Merged w/ master and fixed test failures due to hash randomization.

@tseaver tseaver mentioned this pull request Jul 29, 2015
@joestump

Copy link
Copy Markdown
Owner

@jaitaiwan the main thing you get with tox, as @tseaver mentioned, is being able to run tests against multiple versions of Python locally. Travis does this on PR. I propose we split this into two PRs, get the test coverage merged in, and then move the tox discussion to a 2.0 thread.

@joestump joestump self-assigned this Jul 29, 2015
@jaitaiwan

Copy link
Copy Markdown
Contributor

👍

@jaitaiwan

Copy link
Copy Markdown
Contributor

@tseaver reckon you could open a new PR against master instead?

@tseaver

tseaver commented Jul 30, 2015

Copy link
Copy Markdown
Contributor Author

@joestump I merged with master yesterday, and added a couple of test fixes.

@jaitaiwan

Copy link
Copy Markdown
Contributor

Ugh sorry @tseaver I meant develop instead of master.

@tseaver tseaver closed this by deleting the head repository Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants