Skip to content

Fixes compile issue with snprintf on windows #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joeferner merged 2 commits into from
Nov 18, 2014
Merged

Fixes compile issue with snprintf on windows #171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f3a040
Fixes compile issue with snprintf on windows
wickedest Nov 8, 2014
bbbadd5
Replaces snprintf with std library equiv.
wickedest Nov 8, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/java.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#include "java.h"
#include <string.h>
#include <string>
#ifdef WIN32
#else
#include <unistd.h>
Expand Down Expand Up @@ -1050,10 +1050,11 @@ NAN_METHOD(Java::instanceOf) {
void EIO_CallJs(uv_work_t* req) {
}

static std::string int_to_string(int i) {
char buf[32];
snprintf(buf, sizeof(buf), "%d", i);
return std::string(buf);
template <typename T>
std::string to_string(T value) {
std::ostringstream os;
os << value;
return os.str();
}

#if NODE_MINOR_VERSION >= 10
Expand All @@ -1071,7 +1072,7 @@ void EIO_AfterCallJs(uv_work_t* req) {
int ret = dynamicProxyData->java->getJvm()->GetEnv((void**)&env, JNI_BEST_VERSION);
if (ret != JNI_OK) {
dynamicProxyData->throwableClass = "java/lang/IllegalStateException";
dynamicProxyData->throwableMessage = "Could not retrieve JNIEnv: jvm->GetEnv returned " + int_to_string(ret);
dynamicProxyData->throwableMessage = "Could not retrieve JNIEnv: jvm->GetEnv returned " + to_string<int>(ret);
dynamicProxyData->done = DYNAMIC_PROXY_JS_ERROR;
return;
}
Expand Down