Add support for Java 8.#166
Conversation
|
@joeferner I did some experimentation with Travis and figured out how to test node-java against three JDKs. I could not find a way to run a test matrix with 3 JDKs x 3 Node versions, so the test is only against Node 0.10. As such we probably don't want to check in my revised .travis.yml file. However, you might be interested in the result: https://travis-ci.org/jimlloyd/node-java/builds/38544196 |
By switching to language: java, we can use a full 3x3 test matrix, testing [jdk6, jdk7, jdk8] X [node 0.8, node 0.10, node 0.11].
|
@joeferner I filed an issue with Travis and they responded with the info required to do the full 3x3 test matrix. See the Travis details. |
Joe, feel free to change this to 0.4.3 if you prefer.
|
+1 from me! Looks great @jimlloyd! |
|
Thanks @jsdevel! |
|
@jimlloyd I left a comment regarding the removal of the npm package bump as we usually handle that separately. Outside of that, it would be good if we could squash the commits down to a single commit. |
|
@jsdevel: Sure that all sounds good. I'll submit another PR shortly. |
|
PR #168 supersedes this PR. Closing. |
2 participants
@joeferner This PR replaces #164. I believe this PR now provides a complete solution, but please give it a careful look and let me know if you'd like any changes.
Note that I have add compile-java8.code.sh and created a separate test directory test8 for the java8 unit tests. Currently there is only one java8 test. The test does something reasonable if run on a system that does not have a version 1.8 JRE.