Convert to runtime exceptions - #20
Closed
klyall wants to merge 3 commits into
Closed
Conversation
…. Also allow DefaultHttpClient to be provided to allow it to be configured and prevent an error when doing mulitple calls.
…. Also allow DefaultHttpClient to be provided to allow it to be configured and prevent an error when doing mulitple calls.
…oiler plate code. Also consistently return a JobNotFoundException for Gets and Updates. Finally fix bug where conenction not being closed.
Contributor
|
Pull it please ;) |
Contributor
|
I'm not sure that removing checked exceptions is the way to go. More importantly however, the current pull request does not merge cleanly on top of the current master. |
lilirui520
added a commit
to lilirui520/java-client-api
that referenced
this pull request
Feb 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Convert checked exceptions to runtime exceptions to remove need for boiler plate code.
Also consistently return a JobNotFoundException for Gets and Updates.
Finally fix bug where connection not being closed.