Skip to content

Remove release drafter due to enabled cd#269

Merged
alecharp merged 1 commit into
jenkinsci:masterfrom
jonesbusy-automation:plugin-modernizer-tool
Jan 14, 2025
Merged

Remove release drafter due to enabled cd#269
alecharp merged 1 commit into
jenkinsci:masterfrom
jonesbusy-automation:plugin-modernizer-tool

Conversation

@jonesbusy
Copy link
Copy Markdown
Contributor

Hello github-api developers!

This is an automated pull request created by the Jenkins Plugin Modernizer tool. The tool has applied the following recipes to modernize the plugin:

Remove Release Drafter if CD is enabled

io.jenkins.tools.pluginmodernizer.RemoveReleaseDrafter

Remove Release Drafter if CD is enabled. See https://www.jenkins.io/doc/developer/publishing/releasing-cd/#configure-release-drafter

Copy link
Copy Markdown
Member

@alecharp alecharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jonesbusy this is fine because the configuration only extends the default one. Are the automated pull requests created only in this case? If not, you might want to make sure it does, as plugin maintainers might override the release drafter configuration to suit their liking..

@alecharp alecharp added this pull request to the merge queue Jan 14, 2025
@jonesbusy
Copy link
Copy Markdown
Contributor Author

Good point. While quickly checking on the org I didn't found any custom release drafter config while a plugin use CD.

This is done at this level

https://github.com/jenkins-infra/plugin-modernizer-tool/blob/main/plugin-modernizer-core/src/main/java/io/jenkins/tools/pluginmodernizer/core/recipes/RemoveReleaseDrafter.java#L47-L51`

I would it would be easy to detect if the config only contains _extends: .github and only remove it in that case.

Thanks for your input

Merged via the queue into jenkinsci:master with commit 2152af8 Jan 14, 2025
@jonesbusy jonesbusy deleted the plugin-modernizer-tool branch January 14, 2025 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants