Skip to content

Update to latest github-api 1.99#24

Merged
bitwiseman merged 11 commits into
jenkinsci:masterfrom
bitwiseman:patch-1
Nov 13, 2019
Merged

Update to latest github-api 1.99#24
bitwiseman merged 11 commits into
jenkinsci:masterfrom
bitwiseman:patch-1

Conversation

@bitwiseman
Copy link
Copy Markdown
Contributor

@bitwiseman bitwiseman commented Nov 7, 2019 •
edited
Loading

Also update to latest Jackson2 API and Okio.

Okio 2 is binary compatible with 1.x.

@bitwiseman
Update to latest github-api 1.99
260ba83 
Also update to latest Jackson2 API
@bitwiseman
Update pom.xml
5fc1aee
@bitwiseman
Update pom.xml
571bc7b
@bitwiseman
Fix tests
dddaee6
@bitwiseman
Add okio 2.4
763ccbe 
okio v2 is api and binary compatible with v1.
https://square.github.io/okio/changelog/

okio 1.6.0 that is included with OkHttp2 is over four years old.
@bitwiseman
Incrementalify
238f039
jglick
jglick reviewed Nov 8, 2019
View reviewed changes
Comment thread pom.xml Outdated
Comment thread pom.xml Outdated
Comment thread src/test/java/jenkins/plugins/github/api/SmokeTest.java Outdated
jglick
jglick requested changes Nov 12, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per #24 (comment) you need to either reintroduce JenkinsRule, or simply update jenkins.version.

@bitwiseman bitwiseman requested a review from jglick November 13, 2019 06:07
jglick
jglick requested changes Nov 13, 2019
View reviewed changes
Comment thread pom.xml Outdated
jglick
jglick reviewed Nov 13, 2019
View reviewed changes
Comment thread src/test/java/jenkins/plugins/github/api/SmokeTest.java Outdated
Comment thread src/test/java/jenkins/plugins/github/api/SmokeTest.java Outdated
Comment thread src/test/java/jenkins/plugins/github/api/SmokeTest.java Outdated
Comment thread pom.xml Outdated
@bitwiseman bitwiseman requested a review from jglick November 13, 2019 15:54
@bitwiseman bitwiseman merged commit 2360da3 into jenkinsci:master Nov 13, 2019
@bitwiseman bitwiseman deleted the patch-1 branch November 13, 2019 20:19
@oleg-nenashev
Copy link
Copy Markdown
Member

oleg-nenashev commented Nov 29, 2019

@bitwiseman @KostyaSha FYI GitHub API 1.99+ requires commons codec 1.13 due to hub4j/github-api#551 . It is above the version used by the Jenkins core, but you do not get an error during the exclusion: https://github.com/jenkinsci/github-api-plugin/blob/master/pom.xml#L77-L80 . Same applies to other exclusions. I am putting the new GitHub API Plugin release on hold, because there is a non-zero chance of nuking the GitHub plugin ecosystem by this release. I suggest reviewing it after DW-JW

@oleg-nenashev oleg-nenashev mentioned this pull request Nov 29, 2019
Closed
@oleg-nenashev
Copy link
Copy Markdown
Member

oleg-nenashev commented Jan 6, 2020

This pull request cannot be reverted automatically. I suggest doing it manually so that we do not keep the potentially explosive version in the master branch. WDYT @bitwiseman ?

Also CC @batmat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jglick jglick jglick approved these changes

@stephenc stephenc Awaiting requested review from stephenc

@KostyaSha KostyaSha Awaiting requested review from KostyaSha

Assignees

No one assigned

Labels

dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bitwiseman @oleg-nenashev @jglick @KostyaSha