Converted to Java 11 named module#363
Open
taranion wants to merge 6 commits into
Open
Conversation
Reduced version number of jcodec to 0.2.3, to match depdendency in jcodec-javase
Compile as multi-release JAR Move AWTUtil into different package to prevent package name clash
|
unfortunately it doesn't merge anymore because of conflicts. |
Author
|
Okay, that is not really surprising after nearly 4 years. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't know if you ever consider taking up the work on your code again, but just in case I do have a patch for you that allows you code to better work in Java 11.
When using jcodec + javase in a Java 11 modularized application, the compiler complains about identical package names in jcodec and its child javase (e.g. org.jcodec.scale).
Of course, the package renaming in javase is a breaking change, but necessary.
Regards,
Stefan