Skip to content

Commit 7e64c12

Browse files
committed
Merge release branch 4.6 to master
* 4.6: CLOUDSTACK-9020: UI enhancements from metrics view CLOUDSTACK-9064: The users should be able to create multiple Guest Shared Networks in same Vlan ID, same Physical Network and same network, just with a different IP ranges. CLOUDSTACK-9078: Gave scripts executable permissions. CLOUDSTACK-9076: Changed ownership of directory /var/lib/cloudstack to cloud. Cannot list vlanipranges by keyword
2 parents a1d2c53 + 17eb420 commit 7e64c12

3 files changed

Lines changed: 5 additions & 3 deletions

File tree

engine/orchestration/src/org/apache/cloudstack/engine/orchestration/NetworkOrchestrator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1947,7 +1947,7 @@ public Network createGuestNetwork(long networkOfferingId, final String name, fin
19471947
} else {
19481948
// don't allow to creating shared network with given Vlan ID, if there already exists a isolated network or
19491949
// shared network with same Vlan ID in the zone
1950-
if (_networksDao.countByZoneUriAndGuestType(zoneId, uri, GuestType.Isolated) > 0 || _networksDao.countByZoneUriAndGuestType(zoneId, uri, GuestType.Shared) > 0) {
1950+
if (_networksDao.countByZoneUriAndGuestType(zoneId, uri, GuestType.Isolated) > 0 ) {
19511951
throw new InvalidParameterValueException("There is a isolated/shared network with vlan id: " + vlanId + " already exists " + "in zone " + zoneId);
19521952
}
19531953
}

python/lib/cloudutils/serviceConfigServer.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -121,6 +121,8 @@ def checkHostName():
121121
#distro like sl 6.1 needs this folder, or tomcat6 failed to start
122122
checkHostName()
123123
bash("mkdir /var/log/cloudstack-management/")
124+
bash("chown cloud:cloud -R /var/lib/cloudstack/")
125+
bash("chmod +x -R /usr/share/cloudstack-management/webapps/client/WEB-INF/classes/scripts/")
124126
#set max process per account is unlimited
125127
if os.path.exists("/etc/security/limits.conf"):
126128
cfo = configFileOps("/etc/security/limits.conf")

server/src/com/cloud/server/ManagementServerImpl.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1596,9 +1596,9 @@ public Pair<List<? extends Vlan>, Integer> searchForVlans(final ListVlanIpRanges
15961596
final SearchCriteria<VlanVO> sc = sb.create();
15971597
if (keyword != null) {
15981598
final SearchCriteria<VlanVO> ssc = _vlanDao.createSearchCriteria();
1599-
ssc.addOr("vlanId", SearchCriteria.Op.LIKE, "%" + keyword + "%");
1599+
ssc.addOr("vlanTag", SearchCriteria.Op.LIKE, "%" + keyword + "%");
16001600
ssc.addOr("ipRange", SearchCriteria.Op.LIKE, "%" + keyword + "%");
1601-
sc.addAnd("vlanId", SearchCriteria.Op.SC, ssc);
1601+
sc.addAnd("vlanTag", SearchCriteria.Op.SC, ssc);
16021602
} else {
16031603
if (id != null) {
16041604
sc.setParameters("id", id);

0 commit comments

Comments
 (0)