Broken After 0.24

After updating the lib, there's a chance that the String Array does not work correctly.

I tested below code in obfuscator.io

rows.forEach((row, index) => {
  if (o.val) fn(` CONTENT ${o.val}`)
})

String Array
- Rotate
- Shuffle
- Base64 Encoding
- Threshold - 0.5
Split String Chunk: 15

The above will generate (result differs for each run):

rows['forEach']((c, d) => {
    if (o[b('0x0')])
        fn('\x20CONTENT\x20' + o['val']);
});

rows['forEach']((c, d) => {
    if (o[b('0x1')])
        fn(b('0x0') + o['val']);
});

rows['forEach']((c, d) => {
    if (o['val'])
        fn(b('0x1') + o[b('0x0')]);
});

I was expecting the code to be below instead.

    if (o[b('0x0')])
        fn(b('0x1') + o[b('0x0')]);

And what is wrong?

If you worried about different indexes for string array calls, it is ok, because shuffleStringArray option is enabled.

For example, i tested with the following code:

const rows = [
    {
        val: 'foo'
    },
    {
        val: 'bar'
    },
    {
        val: 'baz'
    }
];

rows.forEach((row, index) => {
  console.log(`CONTENT ${row.val}`);
})

And everything is ok. Order of logs is correct: 'foo', 'bar', 'baz'

Thanks for the quick reply. Actually you need to add the if before the console.log.

It is ok if it does not break anything but for my case, it broke my tests.

There are no errors but the code after the if is not executed.

Can you show me a standalone small example, that is worked before obfuscation and does not work after?

Because even with a condition, the following code works fine for me:

const rows = [
    {
        val: 'foo'
    },
    {
        val: 'bar'
    },
    {
        val: ''
    },
    {
        val: 'baz'
    }
];


rows.forEach((row, index) => {
  if (row.val)
    console.log(`CONTENT ${row.val}`);
})

The problem looks the same as here:
#496

Can you try to search for a minimum standalone example that will reproduce this error?

Also, try to disable shuffleStringArray. Will it help? If not, set all options to false and try again

I've been trying to reproduce a simpler example however not able to reproduce. The source that I have i quite complex which I'm trying to find the pattern that causes it.

Similar to #496 there is no error but produces a wrong result due to the if condition is not met.

My initial suspect was the if condition was wrongly replaced.

Try to play with options as I said before. We should find as many hints as possible

I've turned off every as below and still having wrong results.

    target: 'node',
    compact: false,
    controlFlowFlattening: false,
    deadCodeInjection: false,
    debugProtection: false,
    debugProtectionInterval: false,
    disableConsoleOutput: false,
    identifierNamesGenerator: 'mangled',
    log: false,
    renameGlobals: false,
    rotateStringArray: false,
    selfDefending: false,
    sourceMap: false,
    splitStrings: false,
    splitStringsChunkLength: 15,
    stringArray: false,
    stringArrayEncoding: 'base64',
    stringArrayThreshold: 0.9,
    shuffleStringArray: false,
    transformObjectKeys: false,
    unicodeEscapeSequence: false

If you want, I can email you a sample as my code and the result.

It will be nice! Send it on sanex3339 a t yandex.ru

Finally, found the issue here:

function run(aaa, { missing = '' } = {}) {
    let q = `run ${aaa} `;
    if (missing)
        q += ` SOMETHING ${missing}`;
    return q;
}

console.log(run('dummy', { missing: 'IMPORTANT' }))

The { missing } is renamed but the outside calling function is still using the same signature.

Nice!

PR with the fix #544

Please, try 0.24.5 version

Reopened until approve from your side

It was fixed there:
#496

So expect that it was fixed here too

Comment here if this problem will happen again

Yes. Just tested and it looks good so far. Thanks for the quick fixes!

Nice! Thank you for investigating the problem

Navigation Menu

Repository navigation

Broken After 0.24 #542

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Broken After 0.24 #542

Description

Activity

sanex3339 commented on Feb 3, 2020

sanex3339 commented on Feb 3, 2020

sanex3339 commented on Feb 3, 2020

beeing commented on Feb 3, 2020

sanex3339 commented on Feb 3, 2020

sanex3339 commented on Feb 4, 2020

beeing commented on Feb 4, 2020

sanex3339 commented on Feb 4, 2020

beeing commented on Feb 4, 2020

sanex3339 commented on Feb 4, 2020

beeing commented on Feb 4, 2020

sanex3339 commented on Feb 4, 2020

sanex3339 commented on Feb 4, 2020

sanex3339 commented on Feb 4, 2020

sanex3339 commented on Feb 4, 2020

sanex3339 commented on Feb 5, 2020

sanex3339 commented on Feb 5, 2020

beeing commented on Feb 5, 2020

sanex3339 commented on Feb 5, 2020

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions