Skip to content

Quotes not being properly transformed since 0.18 #319

Closed

Description

@mastef

Expected Behavior ( 0.17 )

var _0x411689 = new Error('Cannot\x20find\x20module\x20\x27' + _0x11707c + '\x27');

Current Behavior ( 0.18 )

var _0x697240 = new Error('Cannot find module '' + _0x7af0b2 + '\x27');

Steps to Reproduce (for bugs)

Your Environment

  • Obfuscator version used: 0.18.1
  • Node version used: 8.9.4

Minimal working example that will help to reproduce issue

var s = "something";
var h=new Error("Cannot find module '"+s+"'");

Activity

  1. sanex3339 commented on Aug 16, 2018

    @sanex3339
    Member

    Hi. Tried here: https://obfuscator.io/

    Result:

    var s = 'something';
    var h = new Error('Cannot\x20find\x20module\x20\x27' + s + '\x27');
    
  2. mastef commented on Aug 16, 2018

    @mastef
    Author

    🤔 must be a setting although I had them all set to false. OK, I'll revert back in a moment

  3. mastef commented on Aug 16, 2018

    @mastef
    Author

    If I add any value to reserved-strings it happens for me : javascript-obfuscator test.js --output test.obf.js --reserved-strings 'a'

    Also happens on the website, just by adding any reserved-string like e.g. a and then pressing the + button. ( Missed that one when testing at first )

  4. sanex3339 commented on Aug 18, 2018

    @sanex3339
    Member

    Will fix it in the upcoming 0.18.2

  5. added a commit that references this issue on Aug 18, 2018
  6. sanex3339 commented on Aug 18, 2018

    @sanex3339
    Member

    PR with fix
    #322

  7. Nantris commented on Aug 23, 2018

    @Nantris

    @sanex3339 thanks for all your hard work on this. Is there at ETA for 0.18.2?

  8. sanex3339 commented on Aug 24, 2018

    @sanex3339
    Member

    Next week. I bery busy right now and before release should fix wrong functions obfuscation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions