Problem with multi-line template literals

Hi, great project. Noticed an obscure bug, though:

Template literals starting with whitespace and containing a newline will sometimes confuse the obfuscator. For example:

function hi() {
    return ` Hello
        There`;
}

This gets obfuscated into:

function hi() {
    return;
    '\x20Hello\x0a\x09There';
}

Note that the return got separated from the literal, so the obfuscated function returns nothing.

The same thing happens if the backtick is immediately followed by a newline, e.g.:

function hi() {
    return `
        Hello There
    `;
}

Related with esprima.
http://esprima.org/demo/parse.html?code=function%20hi()%20%7B%0A%20%20%20%20return%20%60%20Hello%0A%20%20%20%20%20%20%20%20There%60%3B%0A%7D

Same problem as here:
jquery/esprima#1897

Fixed here:
jquery/esprima@9973bab

But no release with fix yet.

You can request faster release here:
jquery/esprima#1882

So, i think i will temporary fix it from my side by correcting wrong AST tree

any ETA on our side? I've pinged on esprima already.

0.14.1 fixed template literals without additional expressions, like example in the first message.
For more complicated expressions is slightly more difficult to find correct solution that won't break anything else.

Fixed. Expect release in a hour or so.

0.14.2 Fixed #181

Should be fixed in [email protected]

it's not working with following syntax
sql_query = select * from blahblah where myids in (${ids.map(d=>'${d}').join(',')}) ${projectWhere} ;

Hi, please format your code, looks like formatting is wrong.

Actual code

sql_query = `select * from sub JOIN ps   ON 
sub.subsystem_id=ps.subsystem_id
                                JOIN project ON project.id = ps.project_id
                                where sub.subsystem_uid in (${ids.map(d=>`'${d}'`).join(',')})
                                ${otherWhere}
                                `;

Created issue: #288

Navigation Menu

Repository navigation

Problem with multi-line template literals #181

11 remaining items

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Problem with multi-line template literals #181

Description

Activity

sanex3339 commented on Jan 24, 2018

sanex3339 commented on Jan 24, 2018

sanex3339 commented on Jan 24, 2018

sanex3339 commented on Feb 13, 2018

sido420 commented on Feb 13, 2018

11 remaining items

sanex3339 commented on Feb 15, 2018

sanex3339 commented on Feb 15, 2018

sanex3339 commented on Feb 15, 2018

bipinpatel-tech commented on Jul 9, 2018

sanex3339 commented on Jul 9, 2018

bipinpatel-tech commented on Jul 10, 2018

sanex3339 commented on Jul 10, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions