Open
Conversation
…production. Also change a typeof x === 'object' to '_.isObject(x)' to prevent false positives on null
…slobo/sails into luislobo-origin/module-loader-only-js
Also adjust tests that run in production mode to not use the session
It's too easy to forget those `.value()`s at the end; see balderdashy@b3d8fd8
Cross out some stuff that's been done
Looks like there was some leftover code from when this file was using machinepack-fs, and both calls to `fs.readSync` should be `fs.readFileSync`
Addresses vulnerability: https://snyk.io/vuln/npm:qs:20170213
…r-wording [patch] Fix lift timeout error wording in http hook
…t's now covered elsewhere in sails-docs). Added FAQ question
Also matches what sails-hook-sockets uses.
(to avoid errors about not having `onlyAllowFromOrigins` set)
This should prevent synchronous hook `initialize` and `configure` functions from inadvertently catching downstream errors.
This is kinda the only way to run the upgrade tool, and it's what we mention in the docs
…dd parley as dep in advance of adding support for 'await' to sails.renderView() (i.e. for email templates).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.