Minor improvements after DWS3 and first #6 rev.#7
Merged
Conversation
Soren implentnting a few fixes of his work where it's available to the deconvolution work. This merge mainly brings over TODO's added in response to WS3 and first review of #6.
kkrempl
approved these changes
Feb 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @kkrempl ,
Here are some updates for your [deconvolution] branch following our design workshop (DSW3), your initial comments on #6, and running all the scripts in the Krempl2021 repository.
The changes included just deal with small interface changes and debugging of ixdat core, not with redoing anything in the deconvolution implementation. Notably:
measurement.__class__ = DecoMeasurementis no longer needed. ATechniqueMeasurement.read()now returns an object of classTechniqueMeasurement- or an inheriting class if the reader specifies it.get_xxxmethods are renamed tograb_xxxto avoid the normal convention with "get" (see, e.g., here). This change excludes the deconvolution module (though I think ultimatelyget_xxxmethods in that module should also be renamed to e.g.calc_xxx)I also made some small style edits so that it could pass flake8 and thus get through Kenneth's pre-push hook. The Krempl2021 repository runs with these changes, given some minor changes of its own which I will PR to you there momentarily.