WIP: Staircase SEC processing and optical fitting#208
Draft
FrederikLizakJohansen wants to merge 18 commits into
Draft
WIP: Staircase SEC processing and optical fitting#208FrederikLizakJohansen wants to merge 18 commits into
FrederikLizakJohansen wants to merge 18 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a deliberately dormant follow-up PR for the Staircase SEC processing and optical fitting work split out of #197.
Do not review or merge this yet. It is opened now only to preserve the work and make the intended follow-up scope visible.
Dependency
This PR depends on #197. Until #197 is merged, this PR will show a lot of overlapping EC-optical reader/measurement changes from the main PR. That is expected.
After #197 lands, this branch should be rebased or otherwise updated onto the merged
mainbranch so the diff is reduced to only the extension work:StaircaseSECStaircaseSECPlotterOpticalCVFittingIf #197 is merged with the same commits, this should become straightforward. If #197 is squash-merged, we should rebase this branch onto the new upstream
mainand replay/cherry-pick the WIP extension commit.Follow-up questions for this PR
The main design work still needed here is:
ECOpticalMeasurementmethod, an ixdatCalculator, or another structured object.OpticalCVFittingso it follows ixdat's calculator pattern and can round-trip cleanly throughas_dict()/from_dict().OpticalCVFittingwith ixdat aliases or configurable series names.The point of splitting this out is to let #197 focus on the core EC-optical measurement/reader functionality while this more experimental processing and fitting work can continue in the background.