Fix EC-Lab column <Ewe/V> to <Ewe>/V> in BiologicReader (#193)#195
Open
FrederikLizakJohansen wants to merge 5 commits into
Open
Fix EC-Lab column <Ewe/V> to <Ewe>/V> in BiologicReader (#193)#195FrederikLizakJohansen wants to merge 5 commits into
FrederikLizakJohansen wants to merge 5 commits into
Conversation
…normalization test
Contributor
Author
|
CI tests for python 3.7 are currently failing due to unrelated issues, which are being addressed separately in PR #194 |
FrederikLizakJohansen
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for Issue #193
Problem:
Some EC-Lab exports use
<Ewe/V>instead of<Ewe>/V>, which causesfix_WE_potentialand other downstream tools to fail.Fix:
This PR normalizes column names in
BiologicReaderduring_update_aliases_and_ensure_essential_series()so that:<Ewe/V>→<Ewe>/V><Ece/V>→<Ece>/V>A test file and integration test confirm this behavior.
Closes #193