Nordic Electrochemistry tdms#167
Merged
Merged
Conversation
da2a735 to
3d6ea33
Compare
ScottSoren
commented
Sep 30, 2024
ScottSoren
left a comment
Member
Author
There was a problem hiding this comment.
Additional notes from Gustav:
- call tstamp "unix_time", at least in export.
- Make a human-readable timestamp (iso 8601)
- Overload some methods to allow multiple units, eg A_el_m2 in ECMeasurement.calibrate (though ideally SI should be default and others like cm^2 should require subsctipt)
- Make default symbol for potential configurable (most electrochemists prefer "E" for potential)
- use "positive" and "negative" instead of "anodic" and "cathodic" when talking about scan direction (probably only affects docstrings)
update nordic reader for missing Z
… on missing or ambiguous macro file(s)
Contributor
|
I've made the following changes to the TDMS reader class:
The following points raised in the review are left for a future PR as they concern the broader ixdat API:
|
Contributor
|
CI tests for python 3.7 are currently failing due to unrelated issues, which are being addressed separately in PR #194 |
Contributor
|
Everything else look great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A reader for the .tdms files made by the labview-based EC4-DAQ software by Nordic Electrochemistry for their potentiostats.
It makes use of the npTDMS package.
The demo runs on these test files.
The feature is available in the pre-release 0.2.9.dev3
(If #166 is merged first, this branch should be rebased and merged to main.)