Unskip biologic tests#165
Conversation
|
Is a changelog entry required for this? |
matenestor
force-pushed
the
unskip_biologic_tests
branch
from
52a4757 to
313670e
Compare
ScottSoren
left a comment
ScottSoren
left a comment
There was a problem hiding this comment.
One question but looks good! Thanks for diagnosing and fixing these tests :)
| elif mpt_name.endswith("=0"): | ||
| # ConstantValue series with "=0" suffix is created when an | ||
| # essential series is not in the parsed dataset. | ||
| # This suffix is removed by Zilien when integrating .mpt files, |
There was a problem hiding this comment.
@matenestor , what is Zilien's behavior when running with EC data incorporated from a Biologic file with Ns? Without Ns?
When does Zilien add an Ns column to the data? Does it remove a "=0" suffix, or just (in contrast to ixdat) not add such a suffix?
There was a problem hiding this comment.
@ScottSoren Zilien will now remove the "=0" suffix created from all columns names containing it, so they are there in a pure form, since ixdat doesn't load the columns as ConstantValue anyway.
Though, there is a column raw_current=0 (at least this one) being produced by Zilien, because back then I didn't think there would be a difference. But I am patching the dataset generation now.
|
I think no Changelog needed for this. Merging (but see questions in comments). Thanks for the PR! |
2 participants
Fixes for failing tests for reading biologic files and checking dataset integration consistency. This is a patch after #134 which now creates
cycle numberandNsseries with=0suffix when they are missing in an .mpt file. (This triggered a change in Zilien code as well 😄 ).