Repository navigation
fix handle 's' case boundary conditions - #17
Merged
Merged
Conversation
Owner
|
Sounds good. |
|
I assume this is meant to fix an 'end of stream' case, but this breaks the 'zero-terminated' aspect of string unpacking. For example, the following now fails: local struct = require "struct"
local packed = struct.pack('ss', "first", "second")
local first, second = struct.unpack('ss', packed)
assert(first == "first", "expected 'first', got '"..first:gsub('%z', "\\0").."'")
assert(second == "second", "expected 'second', got '"..second:gsub('%z', "\\0").."'")with |
Contributor
Author
|
@squeek502 you are right, fix in #19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix handle 's' case boundary conditions