MIA - KatAlderman - Lab-Javascript-Basic-Algorithms - #95
Closed
katalderman wants to merge 1 commit into
Closed
Conversation
sandrabosk
reviewed
Apr 3, 2018
|
|
||
| for (var x=0;x <= hacker1.length; x++) { | ||
| console.log(hacker1.charAt(x).toUpperCase(x)); | ||
| } |
Contributor
There was a problem hiding this comment.
Great approach! The other way could be:
for (var i = 0; i < 1; i++) {
console.log(
hacker1
.split("")
.join(" ")
.toUpperCase()
);
}
| return joinArray; | ||
| } | ||
| console.log(reverseString(hacker1)); | ||
|
|
Contributor
There was a problem hiding this comment.
Again good way of thinking. The same but maybe a bit shorter way would be:
for (var i = 0; i < 1; i++) {
console.log(
hacker1
.split("")
.reverse(" ")
.join("")
);
}
|
|
||
| } | ||
|
|
||
| else if (hacker1 > hacker2){ |
Contributor
There was a problem hiding this comment.
The logic is there but the syntax is not. We could use something like this:
var n = hacker1.localeCompare(hacker2);
if (n === 1) {
console.log("The driver's name goes first");
} else if (n === -1) {
console.log("Yo, the navigator goes first definitely");
} else {
console.log("What?! You both got the same name?");
}
console.log(n);
Try googling .localeCompare() to see how this method works.
Contributor
|
Good job so far. Try finishing the bonus part if you have time. Thank you for submitting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submitting my work for review!