LIS-PTWD-FEB-MargaridaPascoal - #742
Closed
mindfoo wants to merge 1 commit into
Closed
Conversation
|
Hi Margarida, well done ! It's not a problem at all to use split() and join(). There are always several solutions to a lab and you should use the one that you understand and that works best for you. However where you are comparing the two words Cheers :) |
Author
|
Right. Got it. Would have to evaluate each character's case as well then...
Will recheck that.
Thanks for that feedback!
…On Wed, 12 Feb 2020 at 14:49, Part Time WebDev TAs ***@***.***> wrote:
Hi Margarida,
well done ! It's not a problem at all to use split() and join(). There are
always several solutions to a lab and you should use the one that you
understand and that works best for you. However where you are comparing the
two words
palindromeCheck === phraseToCheck
bear in mind the spaces and case sensitivity for both strings. Otherwise
javascript won't evaluate them as the equal.
"Atack Cats" =/= "Atac kCats"
but
"stackcats" === "stackcats"
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#742?email_source=notifications&email_token=AL3VPFGCTT5JRUFTK7GHYSDRCQD6RA5CNFSM4KTEJIOKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELRBDAQ#issuecomment-585240962>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AL3VPFBUBQGUNS5XT7QQNM3RCQD6RANCNFSM4KTEJIOA>
.
|
|
This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request is closed. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried not using split and join but ended up using split and join. Oh well...