[MAD PP] Luis Alberto Peña & Roberto Marrero - #691
Closed
LuisAPPDev wants to merge 1 commit into
Closed
Conversation
ta-web-mad
reviewed
Jan 17, 2020
ta-web-mad
left a comment
ta-web-mad
left a comment
There was a problem hiding this comment.
Hola chicos,
El ejercicio está muy bien! Seguir asi!!
Os he dejado un pequeño comentario respecto al orden de nombres por si queréis echarle un ojo
Sandra
Comment on lines
+49
to
+60
| if (hacker1[0] < hacker2[0]) { | ||
|
|
||
| console.log(`The Driver's name goes first.`); | ||
|
|
||
| } else if (hacker1[0] > hacker2[0]) { | ||
|
|
||
| console.log(`Yo, the navigator goes first definetely.`); | ||
|
|
||
| // Iteration 3: Loops No newline at end of file | ||
| } else { | ||
| console.log(`What?! You both have the same name?`); | ||
| } No newline at end of file |
There was a problem hiding this comment.
La solución que habéis encontrado está bien, pero pensar que si vuestros nombres empiezan por la misma letra no va a seguir comparando y daría el primero que encuentre.
Os animo a que os mireis en mdn el .localeCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Terminado.
Entretenido y útil para coger soltura.