[BCN-FT-012020]-Tarek - #673
Closed
Fiend-Shadow wants to merge 4 commits into
Closed
Conversation
tawebbcn
reviewed
Jan 14, 2020
| } | ||
| console.log(result2); | ||
|
|
||
| for(var i=0;i<=hacker1;i++){ |
Contributor
There was a problem hiding this comment.
In your loop, you should initiate it this way (var i=0; i<hacker1.length; i++)
tawebbcn
reviewed
Jan 14, 2020
| } | ||
|
|
||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
For this iteration, it doesn't work properly, you should compare each letter with the localCompare method
tawebbcn
reviewed
Jan 14, 2020
| var result1=""; | ||
| for (var i=0;i<hacker1.length;i++){ | ||
|
|
||
| result1=result1+" "+hacker1[i].toUpperCase(); |
Contributor
There was a problem hiding this comment.
To avoid to repeat, you can use the operator += like the following example:
result1 += " "+hacker1[i].toUpperCase();
tawebbcn
reviewed
Jan 14, 2020
tawebbcn
left a comment
tawebbcn
left a comment
Contributor
There was a problem hiding this comment.
Good job in general, review the operator to avoid to repeat,
Great 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Day 1 exercise JS.