Skip to content

MIA FTWD APR- Daniela Olano / Nathaniel Carvajal - #382

Closed
dolano13 wants to merge 1 commit into
ironhack-labs:masterfrom
dolano13:master
Closed

MIA FTWD APR- Daniela Olano / Nathaniel Carvajal#382
dolano13 wants to merge 1 commit into
ironhack-labs:masterfrom
dolano13:master

Conversation

@dolano13

@dolano13 dolano13 commented Apr 1, 2019

Copy link
Copy Markdown

No description provided.

@ta-web-mia

Copy link
Copy Markdown

Good job! I did notice one issue though, and it very well may have been a placeholder while you guys were debugging. Right now, your conditional statements that compare the lengths of the two names are hardcoded for 4 characters right now:

image

The following conditional all assume 4 characters in length as well. In order to have the console.log dynamically determine the length of the name, you would want to use string concatenation to reference the length of the name and combine it with the string. Which is fancy talk for doing this:

image

Also I think you may have gotten the driver and navigator mixed up when you were referencing them in these conditionals. Definitely double check these when you get the chance and see if you can fix the issues. If you need help with any of this, definitely let me know and we can take a look at it together.

Other than that, everything else you have seems pretty spot on. If you get a chance to move onto the Lorem Ipsum bonus questions, I would suggest you use the .slice() method to determine the locations of empty spaces and "et"s in the strings. Keep up the good work!

  • Nick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants