Skip to content

MIA FTWD APR Yulia Angel - #381

Closed
salapjaka wants to merge 1 commit into
ironhack-labs:masterfrom
salapjaka:master
Closed

MIA FTWD APR Yulia Angel#381
salapjaka wants to merge 1 commit into
ironhack-labs:masterfrom
salapjaka:master

Conversation

@salapjaka

Copy link
Copy Markdown

done

@ta-web-mia

Copy link
Copy Markdown

Well done! One small thing that I noticed was that in some places of your code, you're declaring your variable on a line without a value, and then placing a value on it in the line immediately after:

image

There's nothing inherently wrong with doing this, but you can simplify things and just assign a value to the variable on the same line you declare it. In other words, you can just erase line 5.

Nitpicks aside, everything you have is functional and well written. If you have extra time and get the chance to work on the Lorem Ipsum bonus questions, you'll definitely have a chance to practice one of the array methods that you used earlier in the assignment. The general idea is that you would convert your string into an array by splitting the string at specific characters. Give it some thought if you get around to it. Keep up the good work!

  • Nick

@ta-web-mia ta-web-mia closed this Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants