Skip to content

Javascript basic algorithms - WDPT Nov - Diogo and Michael - #1714

Closed
micfol wants to merge 5 commits into
ironhack-labs:masterfrom
micfol:master
Closed

Javascript basic algorithms - WDPT Nov - Diogo and Michael#1714
micfol wants to merge 5 commits into
ironhack-labs:masterfrom
micfol:master

Conversation

@micfol

@micfol micfol commented Nov 6, 2021

Copy link
Copy Markdown

Lab completed.

@carlarsmendes

Copy link
Copy Markdown

Interesting and good lab solutions. Good usage of localeCompare even though we didn't talk about it in class - I didn't want to confuse you, but it's great that you used it.
About the method for countWords -> Clearly a regex expressions way which is out of scope for this bootcamp, but I encourage you to look at it at the end of the bootcamp :)
Good usage of switch and good naming of variables
Extra points for the ternary operator -> But be careful when using it, make sure it doesn't decrease the readability
Overall great job guys!

@stale

stale Bot commented Feb 9, 2022

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it didn't have any recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale Bot added the stale label Feb 9, 2022
@stale

stale Bot commented Apr 17, 2022

Copy link
Copy Markdown

This pull request is closed. Thank you.

@stale stale Bot closed this Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants