allow_none=False for all trait types but Instance and Type#7708
Conversation
09475ef to
e068044
Compare
44b4492 to
f2e014d
Compare
|
@minrk
|
|
Good point. I bet it's not all of them. Thanks for this! |
There was a problem hiding this comment.
I think all of these here should all have allow_none=False. I'm guessing that means a default_value must be specified explicitly.
There was a problem hiding this comment.
Yeah, I was just allowing None wherever my change was causing issues. I will add default values.
|
Done, I have replaced the allow_none=True with default values. The chosen default value is the first value proposed in the Enum. Travis is happy. |
|
When #7770 is merged, it will become sensible to have Then, it would be nice to not have any |
9351a39 to
7f8a27e
Compare
|
Removed some redundant |
allow_none=False for all trait types but Instance and Type
|
I think this might be causing some failures in IPython.parallel: "The 'stop_data' trait of a LocalEngineSetLauncher instance must be a dict, but a value of class 'NoneType' (i.e. None) was specified." |
|
Thanks, I'll make sure the parallel tests pass and open a PR with the few remaining changes. This was one part, but there's another as well. |
|
Sorry I missed this one. On this regard, after the default value validation PR is merged, I would like to do the same with |
Closes #7670 .