Skip to content

Keep kitty graphics platform check reachable for mypy on win32 #15419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cristianchiriac wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

Keep kitty graphics platform check reachable for mypy on win32 #15419

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion IPython/core/kitty.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,11 @@ def _supports_kitty_graphics() -> bool:
if forced is not None:
return forced

if sys.platform not in ("darwin", "linux"):
# Compare a copy of sys.platform: mypy treats checks on sys.platform itself as
# constant for the target platform, and with --platform win32 it would then
# flag the rest of this function as unreachable.
platform = sys.platform
if platform not in ("darwin", "linux"):
return False

isatty = getattr(sys.stdout, "isatty", None)
Expand Down
Loading