Conversation
exec('a = 5', {}, []) raises TypeError and can leave a frame whose
f_locals is a list. VerboseTB called .get while checking
__tracebackhide__ and raised AttributeError (ipythongh-12551). Treat
non-mapping locals as having no hide flag.
🤖🤖
Co-authored-by: CenFangyu <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12551
exec('a = 5', {}, [])raisesTypeErrorand can leave a frame whosef_localsis a list.VerboseTBthen called.getwhile checking__tracebackhide__and raisedAttributeError.Treat locals without a callable
.getas having no hide flag so the original exception can be shown. Mapping locals (dict,FrameLocalsProxy) are unchanged.🤖🤖