Conversation
A narration comment above %%magic previously made the cell parse as a line magic named %name. Drop those leading comments so the cell magic runs, matching the existing leading-empty-line cleanup. Fixes ipython#15312
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15312 🤖🤖
A comment (or blank line) above a cell magic is currently treated as the first line of the cell, so
%%timeis parsed as a line magic named%timeand fails withLine magic function \%%time` not found`.This adds a
leading_comment_linescleanup transform, next to the existingleading_empty_linesone. If the first real line of the cell starts with%%, leading comments and blanks are dropped so the cell magic is recognised. Ordinary Python cells and line magics are unchanged.Tests
TransformerManager.transform_cellfor the original reproducercheck_completeso a commented cell magic still waits for a blank lineInteractiveShell.run_cellintegration with a registered cell magic