Refactor Code Expression & Replace unneeded comprehension with generator - #13217

Thanks, I'll review that when I have a bit more time, and try to get that in.

Please try to keep the PRs smaller when you can, touchin 40+ files highly increases the chance that there will be a conflict, and forces reviewers to find long block of time to review the full PR (as mostly the reviewers is just me these days).

Also is that using automating code refactoring ?

In general we also try to avoid refactoring logic for the sake of refactoring logic as this make it harder to find the reasons for something when using git blame. This also affects our ability to automatically backport patches to older branches.

Thanks, I'll review that when I have a bit more time and try to get that in.

Please try to keep the PRs smaller when you can, touching 40+ files highly increases the chance that there will be a conflict, and forces reviewers to find the long block of time to review the full PR (as mostly the reviewers are just me these days).

Also is that using automating code refactoring?

In general we also try to avoid refactoring logic for the sake of refactoring logic as this makes it harder to find the reasons for something when using git blame. This also affects our ability to automatically backport patches to older branches.

Hello, @Carreau thanks for responding to my PR.

Yes, take your time, this pr take for me more than 3 weeks, I use python for a long time that why I try always to understand the magic of code, so I take time to help the community to simplify the code and let the code understood by all users.

Also, the idea about keeping the same logic of code is here cause all the code is just some enhancement and a way to let it more pythonic and human readability at the same time.

So take your time, and read all the changes that i did and we can talk about it.

I've fixed my comment and tried to rebase on master, but can't push on your branch,

the changes I made are there https://github.com/Carreau/ipython/tree/gmaster, most conflicts are dues to removal in master.

Sorry to took a long time to review, next time having smaller set of changes could ensure they are merged faster.

I've fixed my comment and tried to rebase on master, but can't push on your branch,

the changes I made are there https://github.com/Carreau/ipython/tree/gmaster, most conflicts are dues to removal in master.

Sorry to take a long time to review, next time having a smaller set of changes could ensure they are merged faster.

Great! let me fix that conflict and the change then i will ask for a re-review for the PR 🚀

@Carreau Hello is this still active to fix all the conflicts and push to master?

Closing old stale PRs, sorry if this was not addressed, but this has been a few years, so there are few chances of someone actually pushing this through.

Feel free to resubmit if you feel this has a chance to be revived.