Repository navigation
Remove custom rule for deprecation warnigns in __main__ #11333
Description
See https://www.python.org/dev/peps/pep-0565/ we might be able to remove some custom code on 3.7+ and/or have a behavior which is closer to what is defined in the pep.
[EDIT]
This code is now conditionally run on < 3.7 (see #11396), once Python 3.6 is dropped this can actually be removed.
Activity
Carreau commentedon Sep 27, 2018
See #8478 and #8480 for context/historical discussions.
yo-ga commentedon Oct 1, 2018
@Carreau I would like to fix it. BTW, if I get it right, I just need to remove the code added in #8480
Carreau commentedon Oct 1, 2018
As this is fixed in CPython only as 3.7, it way need to be moved to a :
So that once we drop 3.6 we can remove the code.
LucianaMarques commentedon Oct 13, 2018
Hi,
Are there any news on this issue? Was there any pull request already made?
Carreau commentedon Oct 13, 2018
I don't believe any pull request was made. Feel free to take it.
LucianaMarques commentedon Oct 14, 2018
Thank you! I'm reading the links you sent and will come back soon with updates.
LucianaMarques commentedon Oct 14, 2018
I believe that I have a Pull Request already, however I have some doubts about the project's code and haven't ran any tests. Should I make it anyway and discuss it in the PR? Or should we solve it here?
I simply added the
if sys.info_version < (3,7):
...code
mentioned above on the init_deprecation_warnings() functions in the main IPython class. What i understood is that this issue is fixed for python 3.7 but not for older versions, so I guessed this should suffice.
I wanted opinions from more experienced developers in this project to help to check it and to test it.
(I made the PR anyway, I saw in Contributing.md that any PR should be done as soon as there is code to discuss)
Carreau commentedon Oct 14, 2018
Yes, that is the right thing to do. You can run test locally with
iptest, but making the PR will have out continuous integration suite run the tests.Thanks, I'll have a look at the PR.
Carreau commentedon Oct 14, 2018
The code is now conditionally run on < 3.7 (see #11396), once Python 3.6 is dropped this can actually be removed.
Carreau commentedon Oct 14, 2018
Thanks @LucianaMarques !