Skip to content

IPython magic UsageErrors do not set status:error on execute_reply #143

Closed

Description

@takluyver

And consequently they don't stop execution if you've queued several cells to run. Thanks to @nholtz for reporting this on the mailing list.

Activity

  1. added this to the 4.4 milestone on Jun 14, 2016
  2. minrk commented on Jun 15, 2016

    @minrk
    Member

    I think this is something to fix in IPython, since that's what's swallowing the UsageError and printing instead of setting an exception state.

  3. takluyver commented on Jun 15, 2016

    @takluyver
    MemberAuthor

    Could be either. I was thinking of overriding show_usage_error() on the ZMQInteractiveShell class here to track the error. This is like what we already do with _showtraceback().

  4. minrk commented on Jul 6, 2016

    @minrk
    Member

    We should do away with the _showtraceback hack altogether, and get an official mechanism for "this run_cell failed"

  5. takluyver commented on Jul 6, 2016

    @takluyver
    MemberAuthor

    run_cell returns an ExecutionResult instance now, and result.success should be a boolean indicating if it succeeded. Hopefully that provides a good way of doing this.

  6. takluyver commented on Jul 6, 2016

    @takluyver
    MemberAuthor

    (I'm just having a go at this - I'm pointing this out in case we're duplicating effort right now ;-)

  7. added a commit that references this issue on Jul 6, 2016
    a23a0de
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions