Skip to content

Update embedding examples #1392

Description

@jacobwilliams

The internal_ipkernel.py and ipkernel_qtapp.py are out of date. Some issues:

  • It is using PyQt4, which is very old, and not supported on some platforms (e.g. osx-arm64)
  • Explicit use of PyQt means it doesn't work with PySide. Should use qtpy so it will work with Pyside2/6 or PyQt5/6.
  • This line: from IPython.lib.kernel import connect_qtconsole fails on recent ipythons. I think the replacement is from ipykernel import connect_qtconsole. See ModuleNotFoundError: No module named 'IPython.lib.kernel' ipython#13610
  • The connect calls also would need to be updated (I think those are the old style signals).

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions