Skip to content

Ping: Resolved packet loss issue. - #304

Open
apriya-git wants to merge 1 commit into
iputils:masterfrom
apriya-git:flood_ping_issue
Open

apriya-git wants to merge 1 commit into
iputils:masterfrom
apriya-git:flood_ping_issue

Conversation

@apriya-git

@apriya-git apriya-git commented Dec 30, 2020 •

Copy link
Copy Markdown

Due to EINTR & EAGAIN error found 1 packet loss during flood ping test.
Add- read-write for "EINTR" & "EAGAIN" error in "ping_common.c" file.

Signed-off-by: Anu Priya [email protected]

Due to EINTR & EAGAIN error found 1 packet loss during flood ping test.
Add- read-write for "EINTR" & "EAGAIN" error in "ping_common.c" file.

Signed-off-by: Anu Priya <[email protected]>
@apriya-git

Copy link
Copy Markdown
Author

Why merging is blocked?
unable to understand about "base branch requires all commits to be signed"

@pevik

pevik commented Dec 30, 2020

Copy link
Copy Markdown
Contributor

git commit --amend -S

@pevik

pevik commented Dec 31, 2020

Copy link
Copy Markdown
Contributor

You now quit on EINTR(interrupt) only when no POLLERR. Why? That's IMHO wrong. And you should explain the reason in the commit message.

Changing break to continue is most likely wrong. It does not quit on error, which leads to CPU burn. It's easily reproducible on my machine with ping ::1
And again, not explained why you're requesting this change.
Also you haven't updated the comment added in 4aefa8a.

Ping is really hard to read and understand, explanation why is really important. Also ideally explain, how to reproduce your problem.

Mention file ping_common.c is useless (it's obvious from git status).
Not sure what you mean by "Add- read-write".

4aefa8a is a good example of commit message, although some valuable info was hidden in the relevant pull request #75 and issue #74 (e.g. kernel fix: http://patchwork.ozlabs.org/patch/770504/, https://www.mail-archive.com/[email protected]/msg171251.html), I'd prefer these links to be in the commit message.

nit: I'm not convinced about the changes, but if I were, I'd probably suggest to write the condition like
if (!recv_error && (errno == EINTR || errno == EAGAIN))
and have commit subject as ping: Resolved packet loss issue (lower letter in ping and no dot).

@pevik

pevik commented Sep 16, 2021

Copy link
Copy Markdown
Contributor

@apriya-git Could you please describe what you were trying to solve and how to reproduce the issue?

@pevik

pevik commented Mar 20, 2024

Copy link
Copy Markdown
Contributor

@apriya-git Gently ping, could you please describe what you were trying to solve and how to reproduce the issue? Does the problem still exists on the current master or the latest release? How to reproduce it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants