feat(ionicModal): added a variable to know if the modal has been closed from a hide or remove event#3257
feat(ionicModal): added a variable to know if the modal has been closed from a hide or remove event#3257alvaromb wants to merge 2 commits into
Conversation
…d from a hide or remove event Closes ionic-team#2777.
|
Any chance to have this PR merged? We use |
|
Greetings @alvaromb! Thank you very much from all of us on the Ionic team for submitting this pull request. We appreciate your commitment to improving Ionic. Unfortunately, we are unable to merge this particular PR, as it may cause regressions or is already out of date with regard to recent fixes. We apologize, as we know how much time you may have put into the work. We hope you will continue to contribute to Ionic in the future. Please note that we are more likely to merge a smaller PR that has a passing test and changes only one meaningful feature in the project. For more information, please review our Pull Request Guidelines. Best regards, Ionitron |
2 participants
This can be a workaround to some edge cases that happen when the app responds to a modal hide event with some action, but that should not be triggered when the modal is destroyed. Indirectly solves #2777 issue.