fix(vue): guard late swipe cancellation - #31515
Open
dandoingdev wants to merge 1 commit into
Open
dandoingdev wants to merge 1 commit into
dandoingdev wants to merge 1 commit into
Conversation
|
@dandoingdev is attempting to deploy a commit to the Ionic Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #31514
What is the current behavior?
A cancelled swipe's animation callback can run after navigation has changed.
IonRouterOutletlooks up the previous view from the current route and immediately accessesenteringViewItem.ionPageElement. If the view is missing, or its page has been unmounted, cancellation throws a TypeError.A deterministic reproduction using the real router and outlet is included in the issue: reproduction app. It models a late callback explicitly rather than relying on physical gesture timing. The failure was confirmed in Chrome with the published 9.0.6 packages.
What is the new behavior?
aria-hiddenandion-page-hiddencleanup when the page exists, and the completed-swipe navigation behavior.Does this introduce a breaking change?
Other information
Validation:
vitest run tests/unit/swipe-cancel.spec.ts tests/unit/router-outlet.spec.ts: 7 tests pass against the locally built patched Vue package.npm run typecheck,npm run eslint, and Prettier check forIonRouterOutlet.tspass inpackages/vue.npm run bundlepasses inpackages/vue.This changes only the cancellation cleanup branch. It does not change navigation semantics or disable swipe gestures.