Skip to content

docs(vue): fix dead links in vue testing docs and README - #31482

Merged
ShaneK merged 1 commit into
ionic-team:mainfrom
ZainnQureshii:docs/vue-dead-anchors
Sep 25, 2026
Merged

ShaneK merged 1 commit into
ionic-team:mainfrom
ZainnQureshii:docs/vue-dead-anchors

Conversation

@ZainnQureshii

@ZainnQureshii ZainnQureshii commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Issue number: N/A (docs-only link fix)


What is the current behavior?

Two links in the Vue contributor docs point at sections that don't exist:

  • docs/vue/testing.md step 1 links "Build" to ../README.md#building. docs/README.md has no Building section.
  • packages/vue/README.md links "test-app directory" to test/README.md#syncing-local-changes. packages/vue/test/README.md is now a two-line pointer with no such section; the syncing steps live in docs/vue/testing.md.

What is the new behavior?

  • "Build" points at the Building section of packages/vue/README.md, which walks through building core, packages/vue and packages/vue-router, the three projects step 1 names.
  • The sync sentence links to docs/vue/testing.md#syncing-local-changes with an absolute GitHub URL, following the Contributing Guide link in the same README, so it also works on npmjs.com where this README is published.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Docs only, no code changes. Found and prepared with AI assistance (Claude Code); I checked both target headings exist on main, and ran a GitHub Copilot review over the diff.

🤖 Generated with Claude Code

@ZainnQureshii
ZainnQureshii requested a review from a team as a code owner September 24, 2026 21:33
@vercel

vercel Bot commented Sep 24, 2026

Copy link
Copy Markdown

@ZainnQureshii is attempting to deploy a commit to the Ionic Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions Bot added the package: vue @ionic/vue package label Sep 24, 2026
@vercel

vercel Bot commented Sep 25, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
ionic-framework Ready Ready Preview Sep 25, 2026 1:42pm UTC

Request Review

@ShaneK

ShaneK commented Sep 25, 2026

Copy link
Copy Markdown
Member

Awesome, thanks for finding this issue and fixing it for us!

Merged via the queue into ionic-team:main with commit 879e91d Sep 25, 2026
57 checks passed

This branch was successfully deployed

1 active deployment
Preview — 42d7ba8d Deployed Sep 25, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: vue @ionic/vue package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants