feat(datetime): add header parts - #30945
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
thetaPC
commented
Feb 4, 2026
thetaPC
marked this pull request as ready for review
February 4, 2026 22:39
thetaPC
requested review from
OS-jacobbell and
ShaneK
and removed request for
OS-jacobbell
February 4, 2026 22:39
thetaPC
changed the title
brandyscarney
left a comment
brandyscarney
left a comment
Member
There was a problem hiding this comment.
Looks good! A few requests & questions.
| </div> | ||
| </div> | ||
| <div class="calendar-days-of-week" aria-hidden="true"> | ||
| <div class="calendar-days-of-week" aria-hidden="true" part="days-of-week"> |
Member
There was a problem hiding this comment.
Do you think we should call this calendar-days-of-week to match the naming of calendar-header? I am wondering if it's confusing that we have calendar-day and calendar-header but then stop prefixing with calendar. We probably can't enforce this though without causing breaking changes since month-year-button is released already.
ion-datetime,part,calendar-day
ion-datetime,part,calendar-header
ion-datetime,part,datetime-header
ion-datetime,part,days-of-week
ion-datetime,part,month-year-button
ion-datetime,part,next-button
ion-datetime,part,prev-button
ion-datetime,part,prev-next-buttons
ion-datetime,part,time-button
ion-datetime,part,wheel
ion-datetime,part,wheel-item
Contributor
Author
There was a problem hiding this comment.
I'm not against it. The original thought was trying to keep it short but I'm convinced to keep it consistent. We should reconsider the naming during ionic modular work. 0bc7bf3
2 tasks
Co-authored-by: Brandy Smith <[email protected]>
Co-authored-by: Brandy Smith <[email protected]>
Co-authored-by: Brandy Smith <[email protected]>
Co-authored-by: Brandy Smith <[email protected]>
brandyscarney
approved these changes
Feb 18, 2026
This was referenced Feb 20, 2026
This was
linked to
issues
Mar 19, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number: resolves #30083, resolves #30830
What is the current behavior?
There's no way to customize the header when using a grid style. This includes the entire header, prev/next buttons, and the days of the week container. The only section that can customized within the header is the month/year picker. This limits developers from being able to make changes to match their styles.
What is the new behavior?
Does this introduce a breaking change?
Other information
Preview