Skip to content

Nightly: scroll-view is never enabled #10816

@Manduro

Description

@Manduro

Ionic version:
[ ] 1.x
[x] 2.x (2.2.0-201703161917)

I'm submitting a ...
[x] bug report
[ ] feature request
[ ] support request

Current behavior:
All e2e tests that involve scroll listeners have stopped working since 7e9bad5 @manucorporat

Expected behavior:
Scroll listeners should work.

Steps to reproduce:

  1. Start E2E
  2. Try /e2e/infinite-scroll/basic/
  3. Does not work

Related code:

util/scroll-view.ts (comments added)

  init(ele: HTMLElement, contentTop: number, contentBottom: number) {
    assert(ele, 'scroll-view, element can not be null');
    this._el = ele;
    this.initialized = true; // Sets initialized to true
    this.contentTop = contentTop;
    this.contentBottom = contentBottom;

    if (!this.initialized) { // initialized was just set to true, so this will always be false
      this.initialized = true;

      if (this.enabled) {
        this.enable(); // The ScrollView never gets enabled
      }
    }
  }

Other information:
PR #10817 with fix!

Ionic info:

Cordova CLI: 6.5.0 
Ionic Framework Version: 2.2.0-201703161917
Ionic CLI Version: 2.2.1
Ionic App Lib Version: 2.2.0
Ionic App Scripts Version: 1.1.4
ios-deploy version: 1.9.1 
ios-sim version: 5.0.13 
OS: macOS Sierra
Node Version: v6.9.1
Xcode version: Xcode 8.2.1 Build version 8C1002

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions