Skip to content

docs(demos): update skeleton text to latest usage #505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
camwiegert merged 1 commit into from
Mar 5, 2019
Merged

docs(demos): update skeleton text to latest usage #505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"watch-pages": "ts-node -P scripts/tsconfig.json scripts/watch-pages"
},
"dependencies": {
"@ionic/core": "4.0.2",
"@ionic/core": "4.1.0-dev.201902272232.d66b12b",
"@ionic/docs": "^4.0.2",
"@stencil/core": "^0.18.0",
"@stencil/router": "^0.3.3",
Expand Down
82 changes: 26 additions & 56 deletions src/demos/api/skeleton-text/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
</style>
</head>

<body onLoad="onLoad()">
<body>
<ion-app>
<ion-header translucent>
<ion-toolbar>
Expand Down Expand Up @@ -114,21 +114,21 @@ <h3>Primal Heart</h3>
</ion-list>
<ion-list id="skeleton">
<ion-list-header>
<ion-skeleton-text width="80px"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 80px"></ion-skeleton-text>
</ion-list-header>
<ion-item>
<ion-thumbnail slot="start">
<ion-skeleton-text></ion-skeleton-text>
</ion-thumbnail>
<ion-label>
<h3>
<ion-skeleton-text width="80%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 80%"></ion-skeleton-text>
</h3>
<p>
<ion-skeleton-text width="60%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 60%"></ion-skeleton-text>
</p>
<p>
<ion-skeleton-text width="30%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 30%"></ion-skeleton-text>
</p>
</ion-label>
</ion-item>
Expand All @@ -138,13 +138,13 @@ <h3>
</ion-thumbnail>
<ion-label>
<h3>
<ion-skeleton-text width="80%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 80%"></ion-skeleton-text>
</h3>
<p>
<ion-skeleton-text width="60%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 60%"></ion-skeleton-text>
</p>
<p>
<ion-skeleton-text width="30%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 30%"></ion-skeleton-text>
</p>
</ion-label>
</ion-item>
Expand All @@ -154,13 +154,13 @@ <h3>
</ion-thumbnail>
<ion-label>
<h3>
<ion-skeleton-text width="80%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 80%"></ion-skeleton-text>
</h3>
<p>
<ion-skeleton-text width="60%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 60%"></ion-skeleton-text>
</p>
<p>
<ion-skeleton-text width="30%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 30%"></ion-skeleton-text>
</p>
</ion-label>
</ion-item>
Expand All @@ -170,13 +170,13 @@ <h3>
</ion-thumbnail>
<ion-label>
<h3>
<ion-skeleton-text width="80%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 80%"></ion-skeleton-text>
</h3>
<p>
<ion-skeleton-text width="60%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 60%"></ion-skeleton-text>
</p>
<p>
<ion-skeleton-text width="30%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 30%"></ion-skeleton-text>
</p>
</ion-label>
</ion-item>
Expand All @@ -186,13 +186,13 @@ <h3>
</ion-thumbnail>
<ion-label>
<h3>
<ion-skeleton-text width="80%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 80%"></ion-skeleton-text>
</h3>
<p>
<ion-skeleton-text width="60%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 60%"></ion-skeleton-text>
</p>
<p>
<ion-skeleton-text width="30%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 30%"></ion-skeleton-text>
</p>
</ion-label>
</ion-item>
Expand All @@ -202,13 +202,13 @@ <h3>
</ion-thumbnail>
<ion-label>
<h3>
<ion-skeleton-text width="80%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 80%"></ion-skeleton-text>
</h3>
<p>
<ion-skeleton-text width="60%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 60%"></ion-skeleton-text>
</p>
<p>
<ion-skeleton-text width="30%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 30%"></ion-skeleton-text>
</p>
</ion-label>
</ion-item>
Expand All @@ -218,13 +218,13 @@ <h3>
</ion-thumbnail>
<ion-label>
<h3>
<ion-skeleton-text width="80%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 80%"></ion-skeleton-text>
</h3>
<p>
<ion-skeleton-text width="60%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 60%"></ion-skeleton-text>
</p>
<p>
<ion-skeleton-text width="30%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 30%"></ion-skeleton-text>
</p>
</ion-label>
</ion-item>
Expand All @@ -234,13 +234,13 @@ <h3>
</ion-thumbnail>
<ion-label>
<h3>
<ion-skeleton-text width="80%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 80%"></ion-skeleton-text>
</h3>
<p>
<ion-skeleton-text width="60%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 60%"></ion-skeleton-text>
</p>
<p>
<ion-skeleton-text width="30%"></ion-skeleton-text>
<ion-skeleton-text animated style="width: 30%"></ion-skeleton-text>
</p>
</ion-label>
</ion-item>
Expand All @@ -257,39 +257,9 @@ <h3>
#skeleton {
display: block;
}

/* TODO temporary hack for skeleton */
ion-skeleton-text {
display: inline;
height: 100%;
width: auto;
}

#skeleton h3,
#skeleton p {
margin-top: 7px;
margin-bottom: 6px;
}

#skeleton p:last-child {
margin-bottom: 5px;
}
</style>

<script>
/* TODO temporary hack for skeleton */
async function onLoad() {
const skeletonTexts = document.querySelectorAll('ion-skeleton-text');

for (i = 0; i < skeletonTexts.length; ++i) {
const skel = await skeletonTexts[i].componentOnReady();

const childSpan = skel.shadowRoot.querySelector('span');
childSpan.style.height = '100%';
childSpan.style.display = 'block';
}
}

function toggleSkeleton() {
const skeletonEl = document.getElementById('skeleton'),
skeletonStyle = window.getComputedStyle(skeletonEl),
Expand Down