Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ShaneK
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renovate bumped the StackBlitz playground scaffolds to
vite@8, which uses Rolldown as its bundler. Rolldown's native binding fails to load in StackBlitz's WebContainer (Cannot find native binding), so every non-Angular playground broke on start. Tracked upstream in stackblitz/webcontainer-core#2141This pins
viteback to^7(Rollup-based, no Rolldown) in the react, vue, and html scaffolds for v7 and v8, and regenerates their lockfiles to drop therolldownand@rolldown/binding-*entries. Angular already pins[email protected]via the CLI, so it was unaffected and is left alone. Also capsviteat^7in the three vite Renovate rules so it won't re-bump to 8 and reintroduce the failure until we can be sure it's fixed.Easy preview link: https://ionic-docs-git-fix-vite-ionic1.vercel.app/docs/api/tab-bar
Also, I created FW-7632 to undo this later.