Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| ::: | ||
|
|
||
| <!-- Reuse the playground from the Title directory --> | ||
| {/* Reuse the playground from the Title directory */} |
There was a problem hiding this comment.
Switched to the proper syntax for MDX.
|
|
||
|
|
||
| The grid is a powerful mobile-first flexbox system for building custom layouts. It is composed of three units — a grid, [row(s)](row.md) and [column(s)](col.md). Columns will expand to fill the row, and will resize to fit additional columns. It is based on a 12 column layout with different breakpoints based on the screen size. The number of columns can be customized using CSS. | ||
| The grid is a powerful mobile-first flexbox system for building custom layouts. It is composed of three units — a grid, [row(s)](row) and [column(s)](col). Columns will expand to fill the row, and will resize to fit additional columns. It is based on a 12 column layout with different breakpoints based on the screen size. The number of columns can be customized using CSS. |
There was a problem hiding this comment.
Updated paths to no longer reference .md
mapsandapps
left a comment
mapsandapps
left a comment
There was a problem hiding this comment.
All the changes here look good, but I did have some questions. If these are in another PR or something, lmk:
probably relevant to this PR:
- docusaurus.config.js: change lines 42-43 from .md to .mdx? (i didn't look into what this is used for; maybe we need to match both .md and .mdx and return .mdx?)
_templates/README.md: line 24
also, the links in these to /api/foo.md seem to work, but maybe they should be changed for consistency?
- cross-platform.md
- structure.md
- css-shadow-parts.md
- css.variables.md
- 4-0.md
probably not relevant to this PR, but is there a plan to change these things to mdx?
- package.json: use mdx in
npm run spellcheckcommand - .editorconfig: use mdx instead of md (might need no/different rules for mdx, i didn't look into it)
- CONTRIBUTING.md: change filenames
- other lines in the docusaurus.config.js
(i marked request changes, but there may not actually be any changes needed, just let me know what's up 😄)
|
@mapsandapps in regards to the last part in your comment: I plan to do that in a separate PR. |
2 participants
Issue URL: N/A
What is the current behavior?
Some files are using the
.mdextension. Docusaurus v3 has stated that at some point that these files will no longer be parsed as expected and will parsed as CommonMark. They advice to use.mdxinstead.What is the new behavior?
docs/api/files have been switched from.mdto.mdx.mdsame for v5 and v6
Does this introduce a breaking change?
Other information
I'm splitting these into smaller PRs to make it easier to review.
API docs