You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I explored the test structure. Here are my observations ->
The test for lists are stored in test_lists.py and mock data of test lists is stored in tests/testservice/service/list. But this test file contains test for only getting list while changes in Committing organism specification on list upload functionality #36 are in create_list.
Then I saw that you have mentioned extraValue. This is in test_core.py file. Since organism has constraint ONE OF it should be part of testMultiConstraint.
So, should I make changes to testMultiConstraint. Or am I making any mistake?
Activity
julie-sullivan commentedon May 20, 2019
Also, @yochannah you updated the tutorial to include this new feature. Is that right? Can you make that live too?
22PoojaGaur commentedon Feb 25, 2020
Hi @julie-sullivan @yochannah ,
I am new to this org. I would like to take up this issue to start contributing.
22PoojaGaur commentedon Feb 25, 2020
I explored the test structure. Here are my observations ->
listsare stored intest_lists.pyand mock data of test lists is stored intests/testservice/service/list. But this test file contains test for only getting list while changes in Committing organism specification on list upload functionality #36 are in create_list.extraValue. This is intest_core.pyfile. Since organism has constraintONE OFit should be part of testMultiConstraint.So, should I make changes to testMultiConstraint. Or am I making any mistake?
22PoojaGaur commentedon Feb 25, 2020
Also, as you had asked -> it appears
extraValueis indeed Employee.department as used in line 865 in test_core.pyyochannah commentedon Feb 28, 2020
Hey @22PoojaGaur! You would be very welcome to take a look at this :) your deducations sound correct to me!