Skip to content

List upload: add tests for organism #37

Open

Description

@julie-sullivan

See comments here: #36

The testmodel has an idea of an extraValue. I forget what it is, company department maybe?

Activity

  1. julie-sullivan commented on May 20, 2019

    @julie-sullivan
    MemberAuthor

    Also, @yochannah you updated the tutorial to include this new feature. Is that right? Can you make that live too?

  2. 22PoojaGaur commented on Feb 25, 2020

    @22PoojaGaur
    Member

    Hi @julie-sullivan @yochannah ,
    I am new to this org. I would like to take up this issue to start contributing.

  3. 22PoojaGaur commented on Feb 25, 2020

    @22PoojaGaur
    Member

    I explored the test structure. Here are my observations ->

    • The test for lists are stored in test_lists.py and mock data of test lists is stored in tests/testservice/service/list. But this test file contains test for only getting list while changes in Committing organism specification on list upload functionality #36 are in create_list.
    • Then I saw that you have mentioned extraValue. This is in test_core.py file. Since organism has constraint ONE OF it should be part of testMultiConstraint.

    So, should I make changes to testMultiConstraint. Or am I making any mistake?

  4. 22PoojaGaur commented on Feb 25, 2020

    @22PoojaGaur
    Member

    Also, as you had asked -> it appears extraValue is indeed Employee.department as used in line 865 in test_core.py

  5. yochannah commented on Feb 28, 2020

    @yochannah
    Member

    Hey @22PoojaGaur! You would be very welcome to take a look at this :) your deducations sound correct to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions