tag: add delete - #193
Closed
ellakz wants to merge 2 commits into
Closed
tag: add delete#193ellakz wants to merge 2 commits into
ellakz wants to merge 2 commits into
Conversation
added 2 commits
July 9, 2018 17:21
jerrytohvan
approved these changes
Oct 13, 2020
jerrytohvan
approved these changes
Oct 13, 2020
jerrytohvan
approved these changes
Oct 13, 2020
|
|
||
|
|
||
| class Tag(BaseService, All, Find, FindAll, Save): | ||
| class Tag(BaseService, All, Find, FindAll, Save, Delete): |
There was a problem hiding this comment.
@ellakz could you grant me write access so I could merge this?
There was a problem hiding this comment.
@ellakz thanks! strangely it didn't get through. I still might not have the write access
There was a problem hiding this comment.
@apassant hello! Could you help us review on this change? :D
Author
There was a problem hiding this comment.
I think you need access to intercom/python-intercom to merge...
jerrytohvan
approved these changes
Oct 13, 2020
jerrytohvan
approved these changes
Oct 13, 2020
jerrytohvan
approved these changes
Oct 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete tag is enabled in the Intercom API:
https://developers.intercom.com/reference#delete-a-tag
So I enabled it in the python wrapper as well.