Skip to content

Parse path from full url in extract_next_link - #121

Closed
jfeldstein wants to merge 12 commits into
intercom:version-3from
jfeldstein:paging-url
Closed

jfeldstein wants to merge 12 commits into
intercom:version-3from
jfeldstein:paging-url

Conversation

@jfeldstein

Copy link
Copy Markdown

This fixes #120

@jkeyes

jkeyes commented Aug 31, 2016

Copy link
Copy Markdown
Contributor

@jfeldstein Thanks for contributing. v2 is being retired in favour of v3. I see some activity on this project recently, so I'm going to get v3 published and we can work from there.

Comment thread intercom/collection_proxy.py Outdated
# Do this by re-applying the finder_params to the next_page url, since
# Intercom's API seems to drop these
from urlparse import urlparse, parse_qs, urlunparse
from urllib import urlencode

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are these local imports?

@jkeyes

jkeyes commented Nov 15, 2016

Copy link
Copy Markdown
Contributor

@jfeldstein I've just merged #125 into version-3 which provides this functionality.

@jkeyes jkeyes closed this Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants