Conversation
murtron
added a commit
that referenced
this pull request
Jan 29, 2020
* Rewrite contact class and remove deprecated classes * Add support for addressable lists * Add/remove company methods * Update README with tested Contacts functionality * Search collection proxy specs updated * Add base collection proxy class * Nested resource class for API operations * Deserialize addressable lists + use objects for nested operations * Company object to README * Contact spec and merging fix * Contact spec complete * Remove bulk calls from event spec * Use objects for nested resources + add specs * Add test for listing and refactor company spec * Add scroll operation back for companies * Refactor spec for ClientCollectionProxy * BaseCollectionProxy spec + fix deprecation warnings * Add support for data attribute resource * Pin client to > API v2.0 and deprecate app_id/api_key initialization * Add visitor resource back * Check for presence of url when deserializing addressable lists * Don't deserialize addressable lists + set client on contact object * Add bulk jobs + subscriptions * Refactor scroll collection proxy class * Tests for nested resources on contact/company models * Formatting + refactor specs * Move nested resource methods out of initialisor * Readme updates * Update README + add bearer header to client * Remove calls to CGI.escape * Clean up visitor class and document behaviour in readme * Add find operation for tags and remove user tagging * Fix rakefile new line * Code cleanup + fix warnings * Fix contact specs * Add back users and leads under deprecated namespace * Fix entity key for addressable lists * Fix specs * Remove unneeded setting of client * Fix passing down of client with nested resources * Bring back tests for users and leads, fix issues that arose * Fix lead create spec * Add missing files * Fix lead specs * Ensure that all leads operations return lead objects * Allow below version 1.0 * Fix spec and typo * remove contact api header Co-authored-by: Matt Donnelly <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.