Use ErrorPlugin to raise 4xx and 5xx exceptions#272
Merged
Conversation
choran
approved these changes
Jan 18, 2019
choran
left a comment
choran
left a comment
Member
There was a problem hiding this comment.
Looks good, I find it strange that the default is not to return any errors. I think that is a good catch since otherwise it would be very confusing for people since it is not what they would expect
👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The release 4.0.0 introduced an unexpected change in exception handling. HTTPlug does not throw exceptions for client/server errors (4xx/5xx) by default and it encourages creating our own exception layer.
How?
As this intends to be a very lightweight API wrapper, we don't want to do that and we expect the exception handling to be done by the library user.
I included the ErrorPlugin so HTTPlug will start throwing exceptions when a 4xx or 5xx error occurs as it used to do in version 3.